Refactor BasicBlockGraphBuilder::AddBasicBlockFromInstructions.#363
Open
virajbshah wants to merge 1 commit intogoogle:mainfrom
Open
Refactor BasicBlockGraphBuilder::AddBasicBlockFromInstructions.#363virajbshah wants to merge 1 commit intogoogle:mainfrom
BasicBlockGraphBuilder::AddBasicBlockFromInstructions.#363virajbshah wants to merge 1 commit intogoogle:mainfrom
Conversation
boomanaiden154
approved these changes
Aug 4, 2025
Collaborator
boomanaiden154
left a comment
boomanaiden154
left a comment
There was a problem hiding this comment.
Seems reasonable enough to me minus the commit history.
Can you add some more info the commit description on why you're refactoring this out?
| for (const auto& item : items) { | ||
| if (!first) { | ||
| buffer << ","; | ||
| if (first) { |
Collaborator
There was a problem hiding this comment.
Rebase on main rather than the previous PR?
Contributor
Author
There was a problem hiding this comment.
Yep, I was about to put a PR chain up for review and this snuck in with it. Should be fixed now.
* Factor out the per-instruction add to graph logic. * This change is in preparation for further changes to the graph construction logic. * Specifically, this should make the trace graph construction logic cleaner.
virajbshah
force-pushed
the
push-otsxqlkputpm
branch
from
be2d15f to
c0df8c2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.